Use data attribute to determine safe triangle position#2484
Open
ggPeti wants to merge 1 commit intoshoelace-style:nextfrom
Open
Use data attribute to determine safe triangle position#2484ggPeti wants to merge 1 commit intoshoelace-style:nextfrom
ggPeti wants to merge 1 commit intoshoelace-style:nextfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Author
|
Can't see what's wrong with the Vercel deployment. Can someone let me know? |
Collaborator
|
@ggPeti its a TypeScript error: I also approved a full build which has the somes errors in GH actions with linting as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the submenu opens to the right, the safe triangle's position is correct.
But when it gets flipped by the underlying floating-ui library, it becomes incorrect:
This is because the code checks for the
directionstyle property, which is incorrect - thedata-current-placementattribute tells the whole story.